moscajs / aedes-persistence / 28372857090

97%

master: 97%

push

github

feat: persist MQTT 5.0 subscription identifier (#108)

* feat: persist MQTT 5.0 subscription identifier

Store the optional `subscriptionIdentifier` alongside each subscription so
it survives a non-clean session reconnect. It is only written when present,
keeping the stored shape of pre-v5 subscriptions unchanged (and the abstract
conformance suite green).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* test: add subscription-identifier conformance test to the abstract suite

Asserts that an MQTT 5.0 per-subscription `subscriptionIdentifier` round-trips
through the store. Because every backend (redis, mongodb, level) runs this
abstract suite against its own store, this both validates the in-memory
implementation and confirms the backends already preserve the identifier
(they serialize whole subscription objects), so no backend code change is
required for subscription-identifier support.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix: address PR #108 review — clarify trie shape and type the identifier

- Revert the trie.add value to its explicit { qos, rh, rap, nl } shape so it
  no longer reads as if subscriptionsByTopic() carries the Subscription
  Identifier. QlobberSub only retains those four fields, so the topic-match
  path cannot carry the identifier; a comment now states this. The
  load-bearing stored.set(topic, record) still persists it for
  subscriptionsByClient().
- Add subscriptionIdentifier?: number to the subscriptionsByClient return
  type so the public TypeScript contract exposes the field aedes reads back
  on a non-clean reconnect.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

379 of 408 branches covered (92.89%)

Branch coverage included in aggregate %.

34 of 34 new or added lines in 2 files covered. (100.0%)

2497 of 2562 relevant lines covered (97.46%)

339.61 hits per line