supabase / supabase-flutter / 28360025318

86%

Build Type

push

github

Committed by web-flow

Commit Message

chore: enable six DCM rules and fix the violations (#1492)

Part of SDK-1077 (ratcheting down the disabled DCM rule list).

Enables six more DCM rules in the shared `supabase_lints` config and
fixes the few existing violations. Two of these rules had zero
violations; the other four had only a handful each.

## Rules enabled

| Rule | Violations fixed |
|---|---|
| `avoid-constant-conditions` | 0 |
| `avoid-missing-enum-constant-in-map` | 0 |
| `avoid-commented-out-code` | 1 |
| `avoid-unconditional-break` | 1 |
| `avoid-unnecessary-reassignment` | 4 |
| `avoid-wildcard-cases-with-enums` | 4 |

## Changes

- **postgrest**: collapse the `Prefer`/`Accept` header `if`/`else`
reassignments into single assignments (ternary, or a single trailing
assignment in `maxAffected`). Behavior is unchanged.
- **realtime_client**: drop a commented-out line in `RealtimePresence`;
replace the redundant `default` in `connectionState` with explicit
`SocketStates.closed`/`null` cases.
- **supabase / supabase_flutter**: enumerate the remaining enum values
(`PostgresChangeEvent.all`, `AppLifecycleState.inactive`/`.hidden`)
instead of using a wildcard `default`.
- **gotrue test**: replace an `await for` loop with an unconditional
`break` with `.first`.

## Notes

- `avoid-unnecessary-type-assertions` (already enabled, not part of this
PR) surfaces two hits in `postgrest_builder.dart` on the `onError is!
Function(...)` checks in `then()`. It looks like a false positive (it
mirrors the Dart SDK's own `Future.then` signature check), but worth a
look separately.
- Integration tests requiring a local PostgREST server were not run
locally; the postgrest changes are behavior-preserving refactors and the
unit tests pass.

Coverage Stats

17 of 19 new or added lines in 7 files covered. (89.47%)

119 existing lines in 3 files now uncovered.

4128 of 4825 relevant lines covered (85.55%)

3.72 hits per line