KarpelesLab / libwallet / 28355950585

25%

Build Type

push

github

Committed by MagicalTux

Commit Message

wltswap/okx: don't retry deterministic swap reverts (custom program error)

The Solana broadcast retry loop re-fetched a fresh blockhash + re-signed on
any -32002 "Transaction simulation failed", but that envelope covers two
very different cases: a retryable stale blockhash ("... Blockhash not
found") and a DETERMINISTIC program revert ("... Error processing
Instruction 5: custom program error: 0xb"). A fresh blockhash can't cure a
program revert (slippage / unfillable route / etc.), so the loop just burned
3 signing rounds before surfacing the same error.

isRetryableSolanaBroadcast now checks deterministic markers first (custom
program error, error processing instruction, insufficient, slippage,
deserialize) and bails, then allows only genuine transient/blockhash markers
(blockhash, block height exceeded, expired, timeout). Field case
(Jeremy's FLASH swap, custom program error 0xb) now fails fast with its
reason instead of retrying. Adds TestIsRetryableSolanaBroadcast.

Note: this doesn't make a reverting swap succeed — the swap program itself
is rejecting the tx (0xb, deterministic across fresh quotes), which for a
volatile/low-liquidity token is almost always the min-output/slippage check.
The host should raise slippage for such tokens.

Part of unreleased 0.4.72.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Coverage Stats

12 of 0 new or added lines in 0 files covered. (NaN%)

58 existing lines in 1 file now uncovered.

4772 of 20192 relevant lines covered (23.63%)

95.62 hits per line