KarpelesLab / libwallet / 28349713075

25%

Build Type

push

github

Committed by MagicalTux

Commit Message

wlttx: resolve the MAX amount sentinel on native Solana sends

Amount.max(decimals) (the {"v":"MAX"} sentinel) was only resolved for EVM
(resolveEvmMaxAmount); on Solana it was dropped — Sign()==0 made Validate
reject it as "invalid amount", and even past that signAndSendSolana hit a
nil Value(). So hosts had to precompute the max client-side, which is the
class of bug that produced an amount scaled by 10^9.

- Let the MAX sentinel through Validate's amount gate for transfer /
  solana_transfer (IsMax() legitimately has Sign()==0).
- preflightSolanaNativeSend resolves it in place to balance - fee - rent
  via computeSolanaMaxSendable (same as Transaction:maxSendable) using the
  real priority-inclusive fee, so the signer sends a concrete lamport value.
- Fail clearly for the MAX paths that aren't wired yet (ERC-20, SPL) instead
  of nil-deref'ing the sentinel.

Hosts can now pass Amount.max(9) as a native-SOL Transaction.amount and let
libwallet resolve it at build time — no client-side scaling, no quote->send
race.

Also adds the 0.4.71 CHANGELOG entry (covers this + the swap base58 fix).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Coverage Stats

0 of 34 new or added lines in 2 files covered. (0.0%)

118 existing lines in 2 files now uncovered.

4748 of 20119 relevant lines covered (23.6%)

94.64 hits per line