valkyrjaio / ci-phparkitect-php / 28329181674

100%

push

github

[Tests] Change Classes namespace to Fixtures (#101)

# Description

The reusable test-double sub-namespace is being renamed from
`Tests\Classes` to `Tests\Fixtures` across the Valkyrja repos for
clarity and cross-language parity. The shared PHPArkitect ruleset
(`Valkyrja\Arkitect\Rules`, consumed by every repo's `phparkitect.php`)
still asserted the old `Classes` location, so it would reject the
renamed fixtures.

This PR updates the architecture rules to target the new `Fixtures`
namespace. The `*Class` file/suffix convention is intentionally kept —
the rename only affects the namespace/directory, not the class-name
suffix — so the rule asserting fixtures are named `*Class` is left
unchanged.

---

## Types of Changes

- [x] Improvement _(non-breaking change which improves code)_
- [ ] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [ ] Breaking change _(fix or feature that would cause existing
functionality to change)_
- [ ] Documentation improvement

---

## Changes

- **`src/Arkitect/Rules.php`** — updated the "test classes must be
final" rule's namespace exclusion from `Valkyrja\Tests\Classes\Vendor`
to `Valkyrja\Tests\Fixtures\Vendor`
- **`src/Arkitect/Rules.php`** — updated the "testable classes named
appropriately" rule to target `*\Fixtures\` instead of `*\Classes\` (the
`*Class` suffix assertion is retained)
- **`src/Arkitect/Rules.php`** — updated the "testable classes are not
tests" rule to target `*\Fixtures\` instead of `*\Classes\`

3 of 3 new or added lines in 1 file covered. (100.0%)

288 of 288 relevant lines covered (100.0%)

1.05 hits per line