ultimate-notion / ultimate-notion / 28316442975

87%

Build Type

push

github

Committed by web-flow

Commit Message

fix(blocks): Populate children cache when constructing Tabs/Columns (#425)

* fix(blocks): Populate children cache when constructing Tabs/Columns

Offline-constructed `Tabs`/`Columns` dropped their children: `.tabs`/
`.columns` returned `()`, `has_children` was `False`, and build-then-push
uploaded an empty container. `__init__` wrote only the low-level
`obj_ref.<container>.children`, never the high-level `_children` cache that
both the public API and `_chunk_blocks_for_api` read.

Follow the `Table.__init__` pattern: set `self._children` to the wrapped
high-level child blocks and `self.obj_ref.has_children = True`.

Note: `test_modify_tab_blocks` needs live cassette re-recording, as the
corrected flow adds a `children.list` call on first push (matching how
`Table`/`Columns` already work).

Closes #424

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* test(blocks): Re-record tab-icon cassettes for corrected Tabs push flow

`test_modify_tab_blocks` and `test_page_advanced` were failing in replay
(`'None' == '📋'`) — both on this branch and already on `main`. The #424 fix
routes offline-built `Tabs` children through the documented chunking path,
which adds a `children.list` call on first push (matching `Table`/`Columns`),
shifting cassette playback. Re-recorded both against the live API; full
`vcr-only` suite is green (219 passed, 14 skipped).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Coverage Stats

5 of 5 new or added lines in 1 file covered. (100.0%)

78 existing lines in 1 file now uncovered.

6912 of 7926 relevant lines covered (87.21%)

6.08 hits per line