KarpelesLab / libwallet / 28298454376

24%

push

github

wltswap/okx: tolerate quote→execute drift in min-receive tripwire

The 0.4.69 okxAssertMinReceive tripwire compared OKX's execute-time
minReceiveAmount against the stale quote-time Quote.MinAmountOut and
rejected on ANY shortfall. But MinAmountOut is amountOut(quote)×slippage
while OKX recomputes minReceiveAmount from a FRESH quote at execute time,
so normal downward price drift in the seconds between quote and execute
pushes minReceiveAmount a hair under MinAmountOut on perfectly honest
fills — failing every swap. Field report:

  okx: swap minReceiveAmount 713177 is below the approved minimum 713274

(a 0.0136% gap, far inside the slippage band).

Relax the floor to MinAmountOut×(1 − slippageBps): allow the executed
minimum to sit up to one slippage band below the approved minimum — the
drift the user already signalled they tolerate, and what the on-chain
minReceiveAmount itself already enforces against the current price. Still
trips on the order-of-magnitude shortfall a tampered /swap response would
produce. Adds TestOkxAssertMinReceive covering the field case, the relaxed
floor boundary, gross underpayment, and the no-op paths.

Part of unreleased 0.4.70.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

7 of 7 new or added lines in 1 file covered. (100.0%)

4748 of 20075 relevant lines covered (23.65%)

94.53 hits per line