wegamekinglc / Derivatives-Algorithms-Lib / 28294188053

81%

master: 81%

push

github

refactor: brace-init Build() + add CurveSolverOptions_ vocabulary type

Rewrite both CurveCalibrationSpecBuilder_::Build() and
CrossCurrencyCalibrationSpecBuilder_::Build() as aggregate brace-init of the
underlying Spec_ from the builder fields, replacing the member-by-member copy.
Eliminates the silent field-drop hazard when a Spec_ grows: the compiler now
enforces field-count agreement, and round-trip tests guard against order drift.

Add CurveSolverOptions_ to dal-public/src/curvespec.hpp as a public vocabulary
type centralizing the seven shared solver-knob names and the single-curve
defaults (tolerance_ 1e-8, initialGuess_ 0.05). The builders keep their flat
fields so dal-python member-pointer bindings (def_readwrite) and dal-excel
glue stay source-compatible; this is the non-breaking anchor for a future
breaking structural collapse. Sync-reminder comments added above both
builders' solver-field blocks.

Fully backward-compatible: no caller, binding, or Spec_ layout changes.

Tests: add CurveSpecTest.TestCurveSolverOptionsDefaults and per-builder
round-trip tests (CurveSpecTest.TestBuildRoundTripsEveryField,
XccyCalibrationTest.TestBuildRoundTripsEveryField) that populate every field
with distinct sentinels to catch any brace-init order/count mismatch.

Co-Authored-By: Claude <noreply@anthropic.com>

10 of 10 new or added lines in 3 files covered. (100.0%)

6281 of 7724 relevant lines covered (81.32%)

3253418.59 hits per line