wegamekinglc / Derivatives-Algorithms-Lib / 28286058923

81%

master: 81%

Build Type

Pull #147

github

Committed by wegamekinglc

Commit Message

Address PR #147 review: drop dead Smooth arm, fix NodeType_ note, add move-ctor test

Three follow-ups to PR review feedback:

- Delete the entire `case Smooth:` arm from EvalCompiled. The opcode is
  never emitted by Compiler_::Visit* and FuzzyEvaluator_ works on the
  AST, not the compiled stream, so the arm was unreachable dead code
  that also contained a duplicate-condition bug (`if (x < -y)` on both
  branches). Removing it eliminates the dead code and the wrong-looking
  condition without leaving a misleading comment behind. The `Smooth`
  enumerator stays in the hand-written enum to keep the compiled
  nodeStream_ integer contract stable.

- Shorten the NodeType_ deferral note to a one-line NOTE and correct the
  factual claim. The two enums actually agree through Smooth/Sqrt/Log
  (indices 31-33); divergence starts at index 34 because the hand-written
  enum adds Exp there while the generated enum omits it (then Not, Uminus,
  True, False, ConstVar all shift by one). The note no longer asserts a
  specific divergence point -- it just states migration is high-risk and
  deferred, which is accurate either way.

- Add a regression test for the EvaluatorBase_ move-ctor fix. Move-
  constructs an Evaluator_<double> with non-default variablesInit_,
  evaluates an assignment so variables_ diverge from init, then calls
  Init() and asserts the initial values are restored. Verified the test
  crashes against the pre-fix move ctor (out-of-bounds in Init() because
  variablesInit_ is empty after move) and passes against the fix.

Co-Authored-By: Claude <noreply@anthropic.com>

Pull Request Pull Request #147: fix: script-engine correctness bugs (firstElse_ default, EvaluatorBase_ move-ctor)

Coverage Stats

2 of 2 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

6291 of 7801 relevant lines covered (80.64%)

3213901.9 hits per line