KarpelesLab / edwards25519 / 28282072262

84%

push

github

deprecate insecure SignThreshold and SignFromScalar

Mark the experimental threshold/Schnorr multisig entry point (SignThreshold)
and the caller-supplied-nonce primitive (SignFromScalar) with // Deprecated:
notes so callers get editor/staticcheck (SA1019) warnings. These carry the
design-level risks surfaced in the audit: rogue-key and nonce-reuse/Wagner-ROS
attacks for the threshold scheme, and key recovery on nonce reuse/misuse for
the scalar primitive.

Route the safe internal callers (SignRS, PrivateKey.Sign) through an
unexported signFromScalar so they do not depend on the deprecated wrapper.
go vet ignores deprecation, so CI stays green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

4 of 5 new or added lines in 2 files covered. (80.0%)

2977 of 3548 relevant lines covered (83.91%)

6335300.88 hits per line