twbs / bootstrap / 28277231829

94%

main: 96%

push

github

Menu/Popover: setContent show gate + forms-in-menu auto-close (#42551)

* Popover/Tooltip: allow showing content set only via setContent()

show() gated on _isWithContent(), which read config title/content and
ignored content supplied through setContent(). A popover whose content
was set only via setContent() could therefore never be shown. Count
setContent() content in the gate via a shared _hasNewContent() helper.
Fixes #40525.

* Menu: keep open when clicking inside a form within the menu

clearMenus only skipped auto-close for input/select/option/textarea/form
tag names, so clicking a form's label/button/etc. inside a menu closed it
— breaking the documented forms-in-menu example. Skip auto-close for any
click inside a form contained in the menu. Fixes #41803.

* Bump bundlewatch size thresholds

1053 of 1173 branches covered (89.77%)

Branch coverage included in aggregate %.

6 of 6 new or added lines in 3 files covered. (100.0%)

2981 of 3101 relevant lines covered (96.13%)

283.96 hits per line