28257848322
82%

Ran 26 Jun 2026 06:54PM UTC

Jobs 1

Files 46

Run time 1min

Badge

Embed ▾

Committed 26 Jun 2026 06:35PM UTC coverage: 81.713% (+0.01%) from 81.703%

Build # 28257848322

Build Type

push

github

Committed by

web-flow

Commit Message

fix(chart): repair immutable Deployment selector on skyhook->nodewright upgrade (#286)

helm upgrade fails with "spec.selector: field is immutable" when a release first
installed from the pre-rename skyhook-operator chart preserves the controller-
manager Deployment name across the rename (via fullnameOverride/nameOverride, as
AICR does). The selector's app.kubernetes.io/name is sourced from the chart name,
which changed skyhook-operator -> nodewright, and spec.selector is immutable.

- source the controller-manager selector from a shared chart.managerSelectorLabels
  helper used by both the Deployment and the new migration hook
- add a smart pre-upgrade hook (Job + least-privilege ServiceAccount/Role/
  RoleBinding, gated by selectorMigration.enabled, default on) that deletes the
  Deployment only when its live selector does not match the desired one, so helm
  recreates it; verified no-op (no downtime) on normal upgrades
- migrate the maintenance-job image off the now-paywalled bitnami/kubectl to
  alpine/kubectl:1.36.2 pinned by multi-arch digest (closes #207)
- add helm-template chainsaw asserts for the selector pin and each hook resource
- docs: add chart RELEASE_NOTES, update release-process image example and ROADMAP

Fixes #285
Closes #207

Signed-off-by: Brian Lockwood <lockwobr@gmail.com>

Coverage Stats

8110 of 9925 relevant lines covered (81.71%)

9.3 hits per line

Coverage Regressions

Lines	Coverage	∆	File
3	83.98	0.05%	operator/internal/controller/skyhook_controller.go

Jobs

ID	Job ID	Ran	Files	Coverage
1	28257848322.1	26 Jun 2026 06:54PM UTC	46	81.71	GitHub Action Run

NVIDIA / nodewright / 28257848322
82%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 28257848322

NVIDIA / nodewright / 28257848322 82%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 28257848322

NVIDIA / nodewright / 28257848322
82%

README BADGES
x