thanos / terminusdb-client-elixir / 23a9f36d7c5183a6a6eb99aceb648d3ff9b4287c-PR-58

93%

main: 93%

Build Type

Pull #58

github

Committed by thanos

Commit Message

Fix review-0.3.2 issues: RDFList critical bugs, streaming laziness, error handling

Critical (C1-C3):
- closed #59 C1: rdflist_nth variable-index crashed (v.dec missing from localize vars);
  added :dec/:first2/:rest2/:next2 vars, eval(minus) for decrement, unrolled
  recursion one level to avoid infinite Elixir recursion
- closed #60 C2: rdflist_slice silently ignored end_val; rewrote with proper start/end
  bounds using cell navigation + collect
- closed #61 C3: rdflist_swap was a no-op (read-only); added rdflist_cell_at helper and
  delete_triple/add_triple write operations for both cells

closed #62 High (H1-H3):
- H1: rdflist_drop operated on list head not cell at position; split into
  drop(0) head case and drop(n>0) with cell navigation + parent relink
- H2: woql_stream binary-body path used Enum.map (eager); replaced with
  Stream.map for lazy evaluation
- H3: woql_stream used Jason.decode!/1 (crash on malformed JSON); replaced
  with safe Jason.decode/1 returning {:stream_decode_error, ...}

closed #63 Medium (M1-M6):
- M1+M6: graphql_path and prefix_base_path raised on missing DB; refactored
  to return {:error, %Error{reason: :config}} matching execute/3 pattern
- M3: rdflist_push changed from /2 to /3 with new_head_var parameter;
  updated guide, doctest, and tests
- M4: rdflist_clear deletes wrapped inside opt(and_([triple, delete])) blocks
  to guard against unbound variables from failed optional binds
- M5: Documented Patch.before/update asymmetry in docstrings

closed #64 Low (L1-L5):
- L1: False positive — encode_data_list IS called by range_min/max encoders
- L2: Added encode_arithmetic clause for non-variable binary strings
- L3: Fixed guide overview.md insert_document/1 → /2, update_document/1 → /2
- L4: Benchmark.seed_database returns {config, db_name} for cleanup
- L5: Added structural AST assertions to RDFList tests (swap checks for
  AddTriple+DeleteTriple, drop checks for DeleteTriple, nth0 variable-index
  checks for RDFList_... (continued)

Pull Request Pull Request #58: v0.3.2: GraphQL, temporal/Allen, RDF list, CSV/IO, range queries, API…

Coverage Stats

482 of 535 new or added lines in 13 files covered. (90.09%)

2 existing lines in 1 file now uncovered.

1206 of 1299 relevant lines covered (92.84%)

59.0 hits per line