KSDaemon / wampy.js / 28252975982

99%

Build Type

push

github

Committed by web-flow

Commit Message

build(deps-dev): bump eslint tooling and adapt to new lint rules (#666)

* build(deps-dev): bump eslint tooling and adapt to new lint rules

Consolidates the dependabot updates for the eslint toolchain into a
single change:

  - eslint                  ^10.0.0  -> ^10.5.0
  - eslint-plugin-unicorn   ^64.0.0  -> ^69.0.0
  - eslint-plugin-security  ^4.0.0   -> ^4.0.1
  - globals                 ^17.0.0  -> ^17.7.0
  - typescript-eslint       ^8.57.1  -> ^8.62.0

These versions enable new/stricter rules that flagged the existing
codebase. Handled in two ways:

Disabled opinionated rules that conflict with established project style
(in line with the already-disabled prevent-abbreviations, no-null,
prefer-class-fields, ...):
  - unicorn/name-replacements, consistent-boolean-name
  - unicorn/no-this-outside-of-class (mocha this.timeout/skip pattern)
  - unicorn/prefer-await (tests intentionally use .then()/.catch())
  - unicorn/no-top-level-assignment-in-function, prefer-private-class-fields
  - unicorn/no-unnecessary-global-this (isomorphic globalThis access)
  - unicorn/no-global-object-property-assignment (browser entry exports)
  - unicorn/no-computed-property-existence-check
  - unicorn/prefer-https (license-banner URLs)
  - unicorn/prefer-promise-try, prefer-uint8array-base64 (runtime support)
  - unicorn/consistent-class-member-order

Applied the genuinely useful rules: no-useless-else, prefer-regexp-test,
logical-assignment-operators, consistent-conditional-object-spread,
prefer-split-limit, prefer-boolean-return, prefer-minimal-ternary and
no-declarations-before-early-exit in src/cmd; prefer-smaller-scope in
tests; and flattened/de-nested two test callback chains to satisfy
eslint 10.5.0's stricter max-nested-callbacks counting.

* fix(deps): bump ws to ^8.21.0 and override transitive copies

ws 8.0.0 - 8.20.1 are affected by a high-severity uninitialized memory
disclosure (GHSA-58qx-3vcg-4xpx) and a memory-exhaustion DoS
(GHSA-96hv-2xvq-fx4p), fla... (continued)

Coverage Stats

638 of 672 branches covered (94.94%)

39 of 40 new or added lines in 4 files covered. (97.5%)

1 existing line in 1 file now uncovered.

3257 of 3305 relevant lines covered (98.55%)

67.48 hits per line