playwright-community / playwright-go / 28250835416

79%

Build Type

push

github

Committed by web-flow

Commit Message

feat: assemble driver from npm + nodejs.org instead of deprecated CDN (#615)

The Playwright /builds/driver CDN is being deprecated (#593): new driver
versions will stop being uploaded and existing ones will be deleted. Rather
than downloading a prebuilt, fixed-layout zip from that CDN, assemble the
driver from two durable upstream sources, mirroring what the official
playwright-dotnet/python/java ports now do:

  - the platform-independent playwright-core package from the npm registry,
    extracted into <DriverDirectory>/package (contains cli.js); and
  - the matching per-platform Node.js binary from nodejs.org.

The on-disk layout is unchanged, so Run()/Command()/patchDriverBundle() and
the driver-up-to-date check keep working as before.

New environment variables:
  - PLAYWRIGHT_GO_NPM_REGISTRY: npm registry mirror (default registry.npmjs.org)
  - NODE_MIRROR: Node.js distribution mirror (default nodejs.org/dist)
  - PLAYWRIGHT_NODEJS_PATH (existing): when set, skip the Node.js download and
    use a preinstalled Node.js.

Also fixes the silent platform fallthrough behind #584: previously linux/arm
(and other unsupported GOARCH) mapped to the x64 build and failed at runtime
with a cryptic 'exec format error'. nodePlatformSuffix() now returns a clear,
actionable error pointing at PLAYWRIGHT_NODEJS_PATH for platforms without a
prebuilt Node.js binary (e.g. 32-bit ARM).

Extraction is hardened against path traversal (tar/zip slip) since the
registry/mirror hosts are configurable.

Refs #593, #584

Coverage Stats

123 of 177 new or added lines in 1 file covered. (69.49%)

6 existing lines in 1 file now uncovered.

8630 of 10939 relevant lines covered (78.89%)

6955.73 hits per line