decentraland / profile-images / 28242288805

88%

push

github

chore: migrate to @dcl/core-components and drop node-fetch (#159)

* chore: migrate to @dcl/core-components and drop node-fetch

Migrate off @well-known-components/* onto the published @dcl/* packages,
drop node-fetch, and cancel unconsumed fetch response bodies.

Dependency swaps:
- @well-known-components/http-server -> @dcl/http-server
- @well-known-components/metrics -> @dcl/metrics
- @well-known-components/fetch-component -> @dcl/fetch-component
- @well-known-components/test-helpers -> @dcl/test-helpers
- @dcl/platform-server-commons -> @dcl/http-commons
- dcl-catalyst-client -> ^22.0.0
- add @dcl/core-commons for IFetchComponent / IHttpServerComponent types
- remove node-fetch and @types/node-fetch
- add jest / ts-jest / @types/jest devDeps (now peers of @dcl/test-helpers)

Import rewrites move the IFetchComponent / IHttpServerComponent interface
types to @dcl/core-commons while Lifecycle / IConfigComponent /
ILoggerComponent / IMetricsComponent / IBaseComponent stay on
@well-known-components/interfaces. createLocalFetchCompoment ->
createLocalFetchComponent and the integration stub APIs move from sinon
(onFirstCall/reset) to jest (mockResolvedValueOnce/mockReset).

Add a drainResponse helper and use it in reprocess-failures.ts, which only
reads response.status in a loop, to release the native fetch socket.

* ci: bump Node to 24 for the @dcl/core-components engine requirement

@dcl/http-commons@2.0.0 (and the @dcl/core packages) declare engines node >=22.
The build workflow used the reusable apps-with-db-build default (Node 18) and the
Dockerfile installed Node 20, so 'yarn install --frozen-lockfile' failed the engine
check on CI and in the image build. Pass node-version: 24.x to the build workflow
(matching the migrated reference repos) and install Node 24 in the Dockerfile.

160 of 207 branches covered (77.29%)

Branch coverage included in aggregate %.

7 of 10 new or added lines in 5 files covered. (70.0%)

483 of 524 relevant lines covered (92.18%)

20.66 hits per line