urwid / urwid / 28241369171

72%

push

travis-pro

Fix IndexError in _tagmarkup_recurse when a sublist element is empty (#1172)

When a nested list element evaluates to an empty tagmarkup (e.g. `[]`),
`_tagmarkup_recurse` returns `([], [])`.  The attribute-merge block then
tries `al[0]` without first checking that `al` is non-empty, which raises
an `IndexError`.

Guard the merge with `if ral and al:` so that an empty sub-result is
simply skipped rather than crashing.

Fixes: `urwid.decompose_tagmarkup([("attr", "text"), []])` → IndexError

1931 of 2579 branches covered (74.87%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

8432 of 11773 relevant lines covered (71.62%)

7.3 hits per line