supabase / supabase-flutter / 28231764812

86%

push

github

fix(postgrest): return structured error for non-JSON body on 2xx responses (#1474)

## What

When a PostgREST request succeeds (2xx status) but the response body is
not valid JSON (for example, an HTML `502 Bad Gateway` page from a
proxy, or a truncated response), the SDK now throws a structured
`PostgrestException` carrying the raw body, status code, and reason
phrase.

## Why

The previous handling caught the `FormatException` and set `body =
null`, which behaved badly:
- For `.select()` (return type `PostgrestList`), the `null` flowed into
`PostgrestList.from(null)` and crashed with an opaque `TypeError`.
- For `.maybeSingle()`/`.single()`, it silently returned `null`, making
a proxy's HTML error page indistinguishable from "no rows".

This is the Dart equivalent of the supabase-js structured-error /
`throwOnError` behavior, since the Dart builder always throws on error
rather than returning a `{data, error}` shape.

## Not a breaking change

CSV and `pgrst.plan+text` bodies are handled before the JSON decode, so
the only bodies reaching this branch are genuinely malformed. Today
those either crash with an opaque error or return a misleading `null`,
so converting them into a clean `PostgrestException` is a bug fix.

## Tests

Added a `non-json-succ` mock route returning `200` with an HTML body,
covering both `.select()` and `.maybeSingle()` paths.

Closes SDK-1029. Parity with supabase/supabase-js#2398.

4 of 4 new or added lines in 1 file covered. (100.0%)

4105 of 4796 relevant lines covered (85.59%)

3.65 hits per line