supabase / supabase-flutter / 28231764812
92%

DEFAULT BRANCH: main
Ran
Jobs 8
Files 80
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 85.592% (+0.03%) from 85.559%
28231764812

push

github

web-flow 
fix(postgrest): return structured error for non-JSON body on 2xx responses (#1474)

## What

When a PostgREST request succeeds (2xx status) but the response body is
not valid JSON (for example, an HTML `502 Bad Gateway` page from a
proxy, or a truncated response), the SDK now throws a structured
`PostgrestException` carrying the raw body, status code, and reason
phrase.

## Why

The previous handling caught the `FormatException` and set `body =
null`, which behaved badly:
- For `.select()` (return type `PostgrestList`), the `null` flowed into
`PostgrestList.from(null)` and crashed with an opaque `TypeError`.
- For `.maybeSingle()`/`.single()`, it silently returned `null`, making
a proxy's HTML error page indistinguishable from "no rows".

This is the Dart equivalent of the supabase-js structured-error /
`throwOnError` behavior, since the Dart builder always throws on error
rather than returning a `{data, error}` shape.

## Not a breaking change

CSV and `pgrst.plan+text` bodies are handled before the JSON decode, so
the only bodies reaching this branch are genuinely malformed. Today
those either crash with an opaque error or return a misleading `null`,
so converting them into a clean `PostgrestException` is a bug fix.

## Tests

Added a `non-json-succ` mock route returning `200` with an HTML body,
covering both `.select()` and `.maybeSingle()` paths.

Closes SDK-1029. Parity with supabase/supabase-js#2398.

4105 of 4796 relevant lines covered (85.59%)

3.65 hits per line

Coverage Regressions

Lines Coverage ∆ File
25
77.95
0.99% packages/postgrest/lib/src/postgrest_builder.dart
Jobs
ID Job ID Ran Files Coverage
6 postgrest - 28231764812.6 9
84.31
GitHub Action Run
7 supabase - 28231764812.7 15
81.99
GitHub Action Run
8 supabase_flutter - 28231764812.8 11
77.52
GitHub Action Run
7 yet_another_json_isolate - 27986095786.7 1
79.03
GitHub Action Run
8 realtime_client - 28190414303.8 11
88.5
GitHub Action Run
7 gotrue - 28227073552.7 26
84.31
GitHub Action Run
4 functions_client - 27986095786.4 2
97.14
GitHub Action Run
5 storage_client - 28160249676.5 5
92.97
GitHub Action Run
Source Files on build 28231764812