vektah / gqlparser / 944

87%

master: 87%

Pull #442

circleci

validator: reject duplicate union member types

Mirror the duplicate-name pair-scan already applied to fields and enum
values (validator/schema.go) to a union's member-type list. The base and
extension member lists are merged at schema.go:64 (def.Types append) just
like Fields and EnumValues, but no uniqueness check followed, so

    union Foo = A | A
    extend union Foo = A   # (across an extension)

loaded silently. graphql-js rejects this via UniqueUnionMemberTypes with
"Union type Foo can only include type A once."; this matches that wording
and the existing "... can only be defined once." idiom in this file.

10 of 10 new or added lines in 1 file covered. (100.0%)

5102 of 5840 relevant lines covered (87.36%)

1.01 hits per line