uclibs / application_portfolio / 28199780736

74%

push

circleci

Libappo1 post esbuild cleanup build js on deploy (#454)

* Build JavaScript on deploy and remove inline onclick handlers.

Stop committing the esbuild bundle: gitignore application.js artifacts,
remove SKIP_JS_BUILD, build JS in test setup and on deploy via
assets:precompile, and update CI to verify yarn build instead of git diff.

Replace the last dashboard onclick with link_to; sidenav and filter UI
already use Stimulus controllers with specs guarding against window globals
and inline handlers.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Harden post-esbuild cleanup with conventions specs and navigation tests.

Extract JavaScript convention guards, add dashboard sidenav feature
coverage, skip redundant CI bundle rebuilds, and document yarn install
for RSpec.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Wait for deferred Turbo before Turbo.visit in feature specs.

CI headless Chrome can finish page load before the esbuild module
assigns window.Turbo; poll until Turbo.visit is available.

Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Cursor <cursoragent@cursor.com>

321 of 478 branches covered (67.15%)

Branch coverage included in aggregate %.

950 of 1237 relevant lines covered (76.8%)

23.97 hits per line