CiscoDevNet / terraform-provider-cml2 / 28195316227

84%

Build Type

push

github

Committed by web-flow

Commit Message

Handle External State Drift and Idempotent Deletes for Multiple Resources (#194)

* (chore) update deps, changelog, go.work.example

* Fix Terraform state drift for externally deleted nodes

- Treat gocmlclient not-found errors during Node Read as “resource gone” by removing it from Terraform state
- Make Node Delete idempotent when the node is already gone (HTTP 404 / element not found)
- Add acceptance test covering external node deletion and verifying Terraform recreates it on re-plan
- Run gofumpt on touched files

* feat: handle external state drift for more resources

- Add internal/common/not_found.go with IsNotFound(err) helper for CML 404-class errors
- Replace ad-hoc errors.Is checks with common.IsNotFound across provider resources (node, link, lab, group, annotation, user, lifecycle) to treat externally-deleted resources as gone
- Remove/adjust imports and error handling where centralized helper is used
- Add numerous acceptance tests to verify resources are recreated or lifecycle reconciled when deleted/stopped externally (annotation, group, lab, link, node, user, lifecycle)
- Make test configs generate unique names/suffixes to avoid collisions and update test helpers/signatures
- Add internal/testing/gocmlclient_env.go to build gocml client from TF_VAR_* env vars for tests

* fix(lint): golangcilint complaints

* single test only

* Revert "single test only"

This reverts commit b2aac6f75.

* reduce user name length

* (chore) update changelog

* feat(lifecycle): detect and correct dependency drift

- Detect node/link "dependency drift" during plan by inspecting prior node state
- Modify ModifyPlan to read prior nodes and set changeNeeded when drift found
- Add labHasDrift(...) utility to centralize drift detection logic
- Refactor Update to fetch lab once, use labHasDrift or explicit state change to decide actions, and simplify start/stop/wipe + convergence handling
- Add acceptance test to simulate externa... (continued)

Coverage Stats

340 of 486 new or added lines in 27 files covered. (69.96%)

2 existing lines in 1 file now uncovered.

5123 of 6132 relevant lines covered (83.55%)

1902.84 hits per line