benrr101 / node-taglib-sharp / 54280468
93%

DEFAULT BRANCH: develop
Ran
Jobs 1
Files 281
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 92.799% (+0.2%) from 92.616%
54280468

push

appveyor

web-flow 
[ID3v2] Split Frame Factory (#139)

* If statements => dictionary lookup

* Move extended header fields to the frame header class. Add read and render methods to the frame header class.

* Add FrameFactory.createFrameFroMTagBytes

* Add Id3v2Tag.parseFromData and wire up to fromData constructor

* Add FrameFactory.createFrameFromFile

* Implement fromFile for id3v2ExtendedHeader.ts

* Add Id3v2Tag.parseFromFile and wire up to fromFile constructor

* Remove combined constructors

* Reinstate Frame.flags setter for now

* Patch things up so that FrameFactory tests are passing.

* Migrate UnknownFrame to fromBodyBytes - tests passing

* Migrate Private to fromFieldBytes - tests passing

* Migrate UnsynchronizedLyricsFrame to fromFieldBytes - tests passing

* Migrate CommentsFrame to fromFieldBytes - tests passing

* Migrate MusicCdIdentifierFrame to fromFieldBytes - tests passing

* Migrate GenreFrame to fromFieldBytes - tests passing

* Migrate PlayCountFrame to fromFieldBytes - tests passing

* Migrate PopularimeterFrame to fromFieldBytes - tests passing

* RelativeVolumeFrame

* Migrate RelativeVolumeFrame to fromFieldBytes - tests passing

* Migrate SynchronizedLyricsFrame to fromFieldBytes - tests passing

* Migrate TermsOfUseFrame to fromFieldBytes - tests passing

* Rollback mocha to version that supports node 12.16

* Migrate TextInformationFrame to fromFieldBytes - tests passing

* Move UserTextInformationFrame to its own file

* Migrate UserTextInformationFrameTests to fromFieldBytes - tests passing

* Migrate UniqueFileIdentifierFrame to fromFieldBytes - tests passing

* Migrate UserUrlLinkFrame to fromFieldBytes - tests passing

* Migrate UrlLinkFrame to fromFieldBytes - tests passing

* Migrate EventTimeCodeFrame to fromFieldBytes - tests passing

* Migrate AttachmentFrame to fromFieldBytes - tests passing

* Migrate FrameFactory and tests

* Fix the constructor tests

* Remove setData and parseFields

* Remove fieldData

* Fix linkages in i... (continued)

3280 of 4139 branches covered (79.25%)

Branch coverage included in aggregate %.

1997 of 2019 new or added lines in 49 files covered. (98.91%)

13 existing lines in 5 files now uncovered.

27533 of 29065 relevant lines covered (94.73%)

467.87 hits per line

Uncovered Changes

Lines Coverage ∆ File
6
94.74
 2.3% src/id3v2/frames/frameHeader.ts
6
88.9
 -0.83% src/id3v2/id3v2Tag.ts
3
99.06
 -0.94% test-unit/id3v2/frameFactoryTests.ts
2
92.78
 -1.51% test-unit/utilities/testers.ts
1
85.58
 -1.97% src/id3v2/frames/attachmentFrame.ts
1
94.59
 11.67% src/id3v2/frames/frame.ts
1
95.8
 3.92% src/id3v2/frames/frameFactory.ts
1
99.05
 -0.95% src/id3v2/frames/genreFrame.ts
1
97.18
 -2.82% src/id3v2/frames/popularimeterFrame.ts

Coverage Regressions

Lines Coverage ∆ File
8
85.58
 -1.97% src/id3v2/frames/attachmentFrame.ts
2
88.9
 -0.83% src/id3v2/id3v2Tag.ts
1
99.06
 -0.94% test-unit/id3v2/frameFactoryTests.ts
1
96.72
 -1.15% test-unit/id3v2/frameTests.ts
1
97.94
 -2.06% test-unit/id3v2/uniqueFileIdentifierFrameTests.ts
Jobs
ID Job ID Ran Files Coverage
805 805 281
92.8
Source Files on build 54280468