Logflare / logflare / fd4b621b3d6b495888729c0950c7fb971239eecc

82%

push

github

fix(sql): guard nil get_in results used as for-generators (subquery/UNION FROM crashes) (#3642)

* fix(sql): guard nil relation in has_restricted_sources for subquery FROM

Sandboxed endpoint queries with a derived table (subquery) in their FROM
clause crashed validation with 'Protocol.Enumerable not implemented for
Atom'. extract_all_from/1 collects every FROM node, including subquery
relations where get_in(from, ["relation", "Table", "name"]) returns nil;
using nil as a for generator source raised the error. Default to [] so a
non-table relation contributes nothing. The inner subquery's own FROM is
still collected separately, so CTE-membership validation is unaffected.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* test(sql): assert disallowed table in subquery FROM still caught in sandbox

Guards against the nil-relation fix over-suppressing the CTE-membership
check: a non-CTE table inside a sandbox subquery FROM must still error.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* test(sql): cover UNNEST relation in sandboxed FROM

Comma-joined UNNEST is a separate top-level FROM entry whose relation is
not a Table, exercising the same nil-relation path as a derived table.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(sql): guard nil FROM in cte_from_table_aliases for non-SELECT CTE body

Same latent bug as has_restricted_sources: when a CTE body is a UNION
(or VALUES/nested query), get_in(tree, [..., "Select", "from"]) returns
nil and the for-generator crashes with Protocol.Enumerable not
implemented for Atom. The sibling cte_projection_aliases/1 was already
guarded with || []; this one was missed. Verified via mix run that
translating a UNION-bodied CTE now succeeds.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

2 of 2 new or added lines in 2 files covered. (100.0%)

13460 of 16482 relevant lines covered (81.66%)

5050.5 hits per line