harttle / liquidjs / 28188014204

100%

push

github

fix(filters): modulo should follow divisor sign for negative operands (#922)

The `modulo` filter used JavaScript's `%` (truncated remainder, sign
follows the dividend). Shopify/Ruby Liquid uses floored modulo, where the
result takes the sign of the divisor. Since liquidjs advertises Shopify
compatibility, negative operands produced the wrong sign.

Use `((v % arg) + arg) % arg` to match Ruby's `%`. Positive-operand
results are unchanged.

1132 of 1144 branches covered (98.95%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

3015 of 3022 relevant lines covered (99.77%)

21595.02 hits per line