thanos / terminusdb-client-elixir / 128d0c09edccdc8bbc735e57a2b8f103e9a7ae43-PR-30

95%

main: 93%

Pull #30

github

Critical fixes
- C1 — WOQL.triple/3 object encoding (woql.ex): Replaced broken encode_value/1 that left constants as bare strings with proper wrapping: constant strings → NodeValue with node, numbers/booleans → DataValue with xsd-typed data. Added corresponding decode_value/1 clauses for round-tripping. Fixed the unit test that was asserting the broken output.
- C2 — Merge.preview/2 removed (merge.ex): The /api/rebase endpoint ignores the preview flag, so preview/2 performed a real merge. Removed preview/2 and preview!/2, their tests, and all doc/guide references.
High-severity fixes
- H1 — WOQL.type_of/2 (woql.ex): Changed field node → value and encoding from encode_node to encode_value. Updated decoder to match.
- H2 — WOQL.eq/2 left operand (woql.ex): Changed from encode_value (bare strings) to encode_data (proper DataValue wrapping). Updated decoder to use decode_data for both sides.
- H3 — Diff unused options (diff.ex): Removed :repo and :branch from compare_opt type — they were declared but never read.
Medium fixes
- M1/F5 — Commit.history/2 (commit.ex): Made history/2 delegate to log/2 instead of duplicating the implementation. Fixed the doc to honestly state it's an alias, removing the false "additional metadata fields" claim.
- M2/F1/F2/F4 — Doc contradictions: Fixed merge.ex moduledoc (/api/pull → /api/rebase), woql.ex vocabulary table (Eq → Equals), eq/2 doc, and execute/2 → execute/3.
- M3/M4 — Test quality: Tightened the WOQL integration assertion from bindings != nil or inserts != nil or deletes != nil to assert api:status == "api:success" + assert is_list(bindings). Added integration tests for constant-object triples and type_of. Fixed the broken unit test assertion.
Low fixes
- L1/F7: Removed leftover comment in merge.ex.
- L3/F10: Fixed duplicate section numbering in guides/overview.md (two "## 9" → renumbered 9-13).
- F9: Added decode tests for Or, ReadDocument, TypeOf and round-trip tests for Or, ReadDocument, and constant-object Tr... (continued)

123 of 134 new or added lines in 6 files covered. (91.79%)

362 of 380 relevant lines covered (95.26%)

86.99 hits per line