IntelPython / dpnp / 28177613047

78%

push

github

Fix `dpnp.mgrid`/`dpnp.ogrid` inconsistency for complex steps with non-integer magnitude (#2971)

For a complex step, the integer part of its magnitude is the number of
points to generate (start and stop inclusive). The single-slice and
tuple-of-slices code paths disagreed when the step magnitude was **not**
an integer (e.g. `2.5j`):
- the tuple path used `int(abs(step)) - 1` as the divisor (correct),
while
- the single-slice path used the float magnitude `abs(step) - 1` as the
divisor.

As a result `dpnp.mgrid[0:10:2.5j]` and `dpnp.mgrid[0:10:2.5j,]`
produced different arrays, and the single-slice form disagreed with
NumPy.

```python
>>> dpnp.mgrid[0:10:2.5j]      # before: [0. , 6.667]   after: [ 0., 10.]
>>> dpnp.mgrid[0:10:2.5j,][0]  # always: [ 0., 10.]     (matches NumPy)
```

1532 of 2854 branches covered (53.68%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

25974 of 32379 relevant lines covered (80.22%)

8029.48 hits per line