openbraininstitute / neurodamus / 28177838593

91%

push

github

LFP: pass electrode_offsets vector for multi-report support (#541)

In `coreneuron_configuration.py`, `process_section` now passes:

- `Nd.Vector([0, num_electrodes])` when electrodes are present
- `Nd.Vector()` when no electrodes

Companion PR to [neuronsimulator/nrn#3779](https://github.com/neuronsimulator/nrn/pull/3779). Passes electrode offsets as a CSR-style vector instead of a scalar integer to `nrnbbcore_register_mapping`.

Fix: https://github.com/openbraininstitute/neurodamus/issues/553
Fix: https://github.com/openbraininstitute/neurodamus/issues/548

The spec change that triggered this change: https://github.com/openbraininstitute/sonata-extension/pull/34
This matches the updated NEURON-side API that expects an offsets vector.

## Context

This is part of the LFP electrode offsets refactor that prepares the data path for per-report electrode file support (multiple LFP reports with different electrode configurations). See the nrn PR for the full design.

## Testing

- Requires the nrn branch `katta/lfp-electrode-offsets` to be built first
- All existing `test_lfp.py` tests pass unchanged

90 of 93 new or added lines in 5 files covered. (96.77%)

7818 of 8563 relevant lines covered (91.3%)

11.03 hits per line