mongodb-js / devtools-shared / 28175531568

79%

push

github

fix(mongodb-runner): handle arbiter RS convergence race in metadata check (#770)

When a replica set is initiated, the code only waits for a PRIMARY to
appear before proceeding to assertAllServersHaveInsertedLocalMetadata().
An arbiter node may still be transitioning to ARBITER state at that
point, so hello.arbiterOnly can be undefined while this.isArbiter is
already true, causing an immediate "Arbiter flag mismatch" throw.

Fix _ensureMatchingMetadataColl to retry via eventually() when isArbiter
is true but hello has not yet confirmed arbiterOnly, giving the member
time to converge. Also handle the deserialize() ordering where isArbiter
is set after _populateBuildInfo runs by skipping the check when
hello.arbiterOnly is true regardless of the local flag.

Add unit tests covering the retry path, immediate-success path, timeout
propagation, and the deserialize ordering edge case.

1914 of 2686 branches covered (71.26%)

Branch coverage included in aggregate %.

11 of 11 new or added lines in 1 file covered. (100.0%)

4110 of 4940 relevant lines covered (83.2%)

640.45 hits per line