wboayue / rust-ibapi / 28149906549

92%

push

github

Add Error::is_connection_lost() predicate for reconnect loops (#685) (#690)

* Add Error::is_connection_lost() predicate for reconnect loops (#685)

Public predicate so reconnect consumers branch on connection loss without
matching internal Error variants. Matches ConnectionReset/ConnectionFailed
and connection-kind Io errors; excludes Shutdown (intentional teardown) and
ConnectionRejected (unrecoverable handshake refusal).

Internal is_connection_error() now delegates to the public method. README,
stream_retry example, and api-patterns docs adopt the new idiom.

* Break on terminal ConnectionFailed in stream-retry idiom

is_connection_lost() also matches ConnectionFailed, which the transport
returns only after reconnection permanently fails and the client shuts
down. Resubscribing then loops on a dead client (panicking via .expect).
Add a terminal ConnectionFailed arm before the is_connection_lost guard
in the stream_retry example and the README idiom.

* Scope is_connection_lost to recoverable loss; drop ConnectionFailed

Distillation pass (SRP/composability): is_connection_lost lumped terminal
ConnectionFailed (reconnect exhausted) in with recoverable mid-stream loss,
forcing every correct consumer to de-lump it with a preceding match arm.
ConnectionFailed is produced only by reconnect() exhaustion and never reaches
the transport read-error branch that calls is_connection_error, so dropping it
from the predicate leaves reconnect behavior unchanged.

Predicate now matches ConnectionReset + connection-kind Io only; doc reworded
to match. README/example drop the now-redundant terminal arm (ConnectionFailed
falls through to the generic give-up arm), restoring the clean two-arm idiom.

* Update is_connection_error test: ConnectionFailed is terminal

The predicate now treats ConnectionFailed (reconnect exhausted) as terminal,
not a recoverable mid-stream loss. Flip the stale test case expectation from
true to false to match the new contract. This test li... (continued)

8 of 8 new or added lines in 2 files covered. (100.0%)

18110 of 19737 relevant lines covered (91.76%)

28.81 hits per line