databendlabs / openraft / 28148326580

87%

Build Type

push

github

Committed by drmingdrmer

Commit Message

fix: avoid commit channels for complete-only responders

Add ProgressResponder::complete_only() for callers that only need the final
result, and use it in completion-only write paths.

ProgressResponder::new() always creates both commit and completion channels.
Callers such as client_write or client_write_many only use the completion
receiver.  client_write happens to keep the commit receiver in scope until it
is signaled, but client_write_man, in each loop iteration drops the commit
receiver immediately after constructing the responder.

When Raft later commits those entries, ProgressResponder::on_commit() attempts
to send through each abandoned commit channel and logs a warning for every
dropped receiver. This is benign because these call sites deliberately only
wait for completion, but batch writes can produce a large amount of misleading
log noise.

Coverage Stats

28 of 28 new or added lines in 2 files covered. (100.0%)

2 existing lines in 2 files now uncovered.

16844 of 19381 relevant lines covered (86.91%)

162132.76 hits per line