amazon-aurora / babelfish_extensions / 28138125116

77%

main: 77%

push

github

Address review feedback: charset test, RPC-error-context comment, clearer 4-part-name errors

Responds to PR review comments on four-part-name remote procedure execution:

- Document why RPC error capture uses TopMemoryContext: captured remote
  error strings are consumed by linked_server_throw_rpc_error() only after
  the result-draining loop has run SPI/Portal/tuplestore work that can reset
  CurrentMemoryContext, so a shorter-lived allocation could be freed before
  it is read (and the matching pfree in linked_server_clear_rpc_error() would
  then fault). PG_FINALLY still frees them, so there is no leak.

- Clarify the two unsupported-4-part-name error messages in tsqlIface.cpp:
  * The function-call/expression-position message now states that EXEC is the
    supported path for remote procedures.
  * The geospatial-function-call path threw a message that mislabeled a
    spatial/CLR method call (schema.table.column.method) as a remote
    procedure reference; reword it accurately and drop the dead is_xml_method
    branch there (the grammar forces the trailing token to be a geospatial
    method, so it could never be an XML method).
  Regenerate the affected spatial/XML expected outputs (incl. single_db and
  parallel_query variants) for the reworded strings.

- Add tests:
  * four-part-names-vu-verify: negative case for a remote function call via a
    4-part name in expression position (rejected at parse time).
  * openquery-vu-verify: explicit charset round-trip of a non-Unicode varchar
    literal and an nvarchar (N'...') literal in one OPENQUERY, guarding the
    UTF-8 client charset set in linked_server_establish_connection().

2 of 2 new or added lines in 1 file covered. (100.0%)

54908 of 71132 relevant lines covered (77.19%)

393572.87 hits per line