pulibrary / bibdata / c2f469c0-6041-40fe-8cea-df826e3685a3
90%
main: 91%

LAST BUILD BRANCH: dense-vector-field
DEFAULT BRANCH: main
Ran
Jobs 2
Files 199
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 89.991% (-0.7%) from 90.701%
c2f469c0-6041-40fe-8cea-df826e3685a3

Pull #3362

circleci

christinach 
Push the round to 6 digits to the python api.
After further testing the cause of the failure PulSolrJsonWriter to
post to solr is that the float32 vectors also included scientic notation e or E.
Solr's format type and builder class thinks that the serialized
payload that includes the float32 with scientific notation- json_package - and is posted via http from bibdata
is a String and not the expected float32 number type solr expects.

\n\tat org.apache.solr.update.DocumentBuilder.addField(DocumentBuilder.java:67)\n\tat org.apache.solr.update.DocumentBuilder.addOriginalField(DocumentBuilder.java:304)\n\tat org.apache.solr.update.DocumentBuilder.toDocument(DocumentBuilder.java:193)\n\t... 74 more\nCaused by: java.lang.ClassCastException: class java.lang.String cannot be cast to class java.lang.Number (java.lang.String and java.lang.Number are in module java.base of loader 'bootstrap')\n\tat
org.apache.solr.util.vector.DenseVectorParser.parseIndexVector(DenseVectorParser.java:72)\n\tat
 org.apache.solr.util.vector.DenseVectorParser.parseVector(DenseVectorParser.java:45)\n\tat
org.apache.solr.util.vector.FloatDenseVectorParser.getFloatVector(FloatDenseVectorParser.java:34)\n\tat
org.apache.solr.schema.DenseVectorField.createField(DenseVectorField.java:273)\n\tat
 org.apache.solr.schema.DenseVectorField.createFields(DenseVectorField.java:237)\n\t... 77 more\n",
Pull Request #3362: Dense vector field - text_embedding

42 of 58 new or added lines in 3 files covered. (72.41%)

80 existing lines in 6 files now uncovered.

11472 of 12748 relevant lines covered (89.99%)

67.78 hits per line

Uncovered Changes

Lines Coverage ∆ File
15
73.21
 embedding_service/src/embedding_client.rs
1
23.36
 -0.22% marc_to_solr/lib/pul_solr_json_writer.rb

Coverage Regressions

Lines Coverage ∆ File
26
67.09
 -32.91% app/models/index_manager.rb
19
29.41
 -55.88% marc_to_solr/lib/electronic_portfolio_builder.rb
19
73.17
 -23.17% marc_to_solr/lib/process_holdings_helpers.rb
14
92.51
 -6.17% marc_to_solr/lib/princeton_marc.rb
1
84.62
 -7.69% app/services/alma/indexer.rb
1
70.83
 -4.17% app/services/index_functions.rb
Jobs
ID Job ID Ran Files Coverage
1 c2f469c0-6041-40fe-8cea-df826e3685a3.1 93
90.12
2 c2f469c0-6041-40fe-8cea-df826e3685a3.2 106
89.6
Source Files on build c2f469c0-6041-40fe-8cea-df826e3685a3