stacklok / toolhive / 28129340367
67%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 759
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 67.274% (+0.1%) from 67.154%
28129340367

push

github

web-flow 
Remove redundant stale-ref scans from config controller watches (#5626)

* Remove dead reference-lookup helpers from controllerutil

The field-indexer rollout (#5599) replaced every production caller of
FindReferencingMCPServers, FindReferencingMCPRemoteProxies, and
FindWorkloadRefsFromMCPServers with indexed MatchingFields queries. They are
now reachable only by their own tests, which Go won't flag — so they quietly
read as load-bearing. Delete the three helpers and their tests.

Resolves the dead-code review note on #5599; see #5607.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Drop stale-ref scan from OIDC/ToolConfig/Telemetry watches

The workload watch handlers each enqueued the current ref and then ran a
hand-rolled "stale ref" scan: list every config of the type and scan each
one's Status.ReferencingWorkloads for the changed workload. That scan is
redundant — EnqueueRequestsFromMapFunc already runs the map function on both
the old and new object (controller-runtime v0.23.3), so returning only the
currently-referenced config also enqueues the previously-referenced one on a
ref change or deletion. Reconcile rebuilds the list from the field index every
run, so pruning still happens; missed events heal on resync.

Simplify each handler to the current-ref enqueue and add a
GenerationChangedPredicate so the watch only fires on spec changes. Verified
by the OIDC/ToolConfig/Telemetry integration suites (deref + delete -> prune).

See #5607.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Drop stale-ref scan from Authz and Webhook watches

Simplify the workload watch handlers to enqueue only the currently-referenced
config and delete the redundant stale-ref scan, relying on the framework's
old+new map-function enqueue (as in the OIDC/ToolConfig/Telemetry change).
Removes MCPAuthzConfig's findStaleRefs method and adds a
GenerationChangedPredicate to its watches; MCPWebhookConfig already had one.
Handle... (continued)

76 of 99 new or added lines in 6 files covered. (76.77%)

116 existing lines in 10 files now uncovered.

69351 of 103088 relevant lines covered (67.27%)

65.52 hits per line

Uncovered Changes

Lines Coverage ∆ File
6
76.09
 -2.05% cmd/thv-operator/controllers/mcpauthzconfig_controller.go
6
66.54
 20.08% cmd/thv-operator/controllers/mcpoidcconfig_controller.go
6
62.9
 21.76% cmd/thv-operator/controllers/mcptelemetryconfig_controller.go
3
62.9
 10.73% cmd/thv-operator/controllers/toolconfig_controller.go
2
79.32
 14.14% cmd/thv-operator/controllers/mcpexternalauthconfig_controller.go

Coverage Regressions

Lines Coverage ∆ File
60
62.21
 -4.4% pkg/workloads/manager.go
19
2.79
 -3.31% cmd/thv-operator/api/v1alpha1/zz_generated.deepcopy.go
19
44.91
 -0.59% cmd/thv-operator/api/v1beta1/zz_generated.deepcopy.go
6
71.7
 -1.93% pkg/runner/config.go
5
0.0
 -100.0% pkg/workloads/sysproc_unix.go
3
71.85
 -1.11% pkg/ignore/processor.go
1
76.09
 -2.05% cmd/thv-operator/controllers/mcpauthzconfig_controller.go
1
66.54
 20.08% cmd/thv-operator/controllers/mcpoidcconfig_controller.go
1
62.9
 21.76% cmd/thv-operator/controllers/mcptelemetryconfig_controller.go
1
62.9
 10.73% cmd/thv-operator/controllers/toolconfig_controller.go
Jobs
ID Job ID Ran Files Coverage
1 28129340367.1 759
67.27
 GitHub Action Run
Source Files on build 28129340367