stacklok / toolhive / 28121935376

67%

Build Type

push

github

Committed by web-flow

Commit Message

Remove dead session-factory aggregation and composite mirrors (#5625)

* Remove the session-factory aggregation mirror

The core is the single source of capability aggregation on the Serve path
(AdvertiseFromCore), so the session factory's parallel aggregation is dead code. Part of the
#5621 Stage 2 dead-factory-mirror removal:

- session/factory.go: remove the `aggregator` field, `WithAggregator`,
  `buildRoutingTableWithAggregator`, and the `if f.aggregator != nil` branch — makeBaseSession
  always builds the routing table from raw backend capabilities (no overrides/conflict-
  resolution/filter; the core owns that). makeBaseSession's now-always-nil error return is
  dropped (+ its two callers).
- aggregator: remove `Aggregator.ProcessPreQueriedCapabilities` (interface + impl + regenerated
  mock) — its only caller was buildRoutingTableWithAggregator.
- cli/serve.go: inline the trivial createSessionFactory to NewSessionFactory and drop the
  WithAggregator(agg) wiring (agg still feeds the core via Config.Aggregator).

Part of #5621.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Remove session-factory composite/telemetry mirrors

The core owns composite-tool execution (executeComposite) and workflow telemetry
(core_telemetry.go's telemetryComposer, #5561), and nothing sets FactoryConfig.WorkflowDefs/
ComposerFactory on the Serve path (server.New and the integration harness leave them unset),
so the session factory's composite-tool decorator and its workflow-executor telemetry never
run. Remove them — the second half of #5621 Stage 2:

- sessionmanager/factory.go: delete compositeToolsDecorator, composerWorkflowExecutor,
  workflowExecutorInstruments + newWorkflowExecutorInstruments + wrapExecutor, and
  telemetryWorkflowExecutor; drop the instruments param from buildDecoratingFactory. The
  optimizer decorator and its telemetry (monitorOptimizer/telemetryOptimizer) are untouched.
- FactoryConfig: drop the dead WorkflowDefs ... (continued)

Coverage Stats

8 of 9 new or added lines in 4 files covered. (88.89%)

83 existing lines in 6 files now uncovered.

69608 of 103643 relevant lines covered (67.16%)

66.24 hits per line