• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

stacklok / toolhive / 28121935376
67%

Build:
DEFAULT BRANCH: main
Ran 24 Jun 2026 06:55PM UTC
Jobs 1
Files 764
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

24 Jun 2026 06:49PM UTC coverage: 67.161% (+0.03%) from 67.133%
28121935376

push

github

web-flow
Remove dead session-factory aggregation and composite mirrors (#5625)

* Remove the session-factory aggregation mirror

The core is the single source of capability aggregation on the Serve path
(AdvertiseFromCore), so the session factory's parallel aggregation is dead code. Part of the
#5621 Stage 2 dead-factory-mirror removal:

- session/factory.go: remove the `aggregator` field, `WithAggregator`,
  `buildRoutingTableWithAggregator`, and the `if f.aggregator != nil` branch — makeBaseSession
  always builds the routing table from raw backend capabilities (no overrides/conflict-
  resolution/filter; the core owns that). makeBaseSession's now-always-nil error return is
  dropped (+ its two callers).
- aggregator: remove `Aggregator.ProcessPreQueriedCapabilities` (interface + impl + regenerated
  mock) — its only caller was buildRoutingTableWithAggregator.
- cli/serve.go: inline the trivial createSessionFactory to NewSessionFactory and drop the
  WithAggregator(agg) wiring (agg still feeds the core via Config.Aggregator).

Part of #5621.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Remove session-factory composite/telemetry mirrors

The core owns composite-tool execution (executeComposite) and workflow telemetry
(core_telemetry.go's telemetryComposer, #5561), and nothing sets FactoryConfig.WorkflowDefs/
ComposerFactory on the Serve path (server.New and the integration harness leave them unset),
so the session factory's composite-tool decorator and its workflow-executor telemetry never
run. Remove them — the second half of #5621 Stage 2:

- sessionmanager/factory.go: delete compositeToolsDecorator, composerWorkflowExecutor,
  workflowExecutorInstruments + newWorkflowExecutorInstruments + wrapExecutor, and
  telemetryWorkflowExecutor; drop the instruments param from buildDecoratingFactory. The
  optimizer decorator and its telemetry (monitorOptimizer/telemetryOptimizer) are untouched.
- FactoryConfig: drop the dead WorkflowDefs ... (continued)

8 of 9 new or added lines in 4 files covered. (88.89%)

83 existing lines in 6 files now uncovered.

69608 of 103643 relevant lines covered (67.16%)

66.24 hits per line

Uncovered Changes

Lines Coverage ∆ File
1
34.06
-0.85% pkg/vmcp/cli/serve.go

Coverage Regressions

Lines Coverage ∆ File
62
61.69
-5.18% pkg/workloads/manager.go
6
20.11
-3.45% pkg/client/manager.go
6
76.15
-5.5% pkg/secrets/keyring/keyctl_linux.go
5
0.0
-100.0% pkg/workloads/sysproc_unix.go
2
96.48
0.0% pkg/authserver/storage/memory.go
2
93.94
-6.06% pkg/foreach/foreach.go
Jobs
ID Job ID Ran Files Coverage
1 28121935376.1 24 Jun 2026 06:55PM UTC 764
67.16
GitHub Action Run
Source Files on build 28121935376
  • Tree
  • List 764
  • Changed 15
  • Source Changed 6
  • Coverage Changed 15
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #28121935376
  • 12fb161b on github
  • Prev Build on main (#28121606117)
  • Next Build on main (#28125239026)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc