reactivando / use-pubsub-js / 28118410624

100%

master: 80%

push

github

docs: v2 migration plan & design record (research, reviews, decisions) (#76)

* docs: add v2 migration & improvement plan (internal pub/sub module)

Synthesized from 5 parallel research passes (pubsub-js surface/usage,
new-API design, React perf/integration, testing strategy, packaging/DX).
docs/migration-v2/: overview, API design, React improvements, testing
strategy, packaging/DX, milestones, ideas backlog, decisions/risks, and a
machine-readable milestones.yml. Draft for adversarial review.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* docs: adjudicate adversarial review + amend v2 plan (08-review-verdicts)

Three adversarial reviewers (API/architecture, testing/safety, React)
challenged the plan; 08-review-verdicts.md records every verdict and the
amendments (authoritative over 01-07 where they conflict).

Verified BLOCKERs folded in:
- example/ app imports pubsub-js directly and isn't built by CI -> breaks
  silently in v2 (M2 updates the import + adds an example build gate).
- delivery must pass the ORIGINAL token (string|symbol), not String(token),
  to match identity-keying + the typed API (fix in 01).

Other accepted changes: useMemo the hook return objects in core (exhaustive-
deps infinite-loop risk) and DROP the useLayoutEffect swap (cargo-cult);
coverage thresholds + e2e runtime smoke move to M1; new contract cases;
symbol-identity test as it.todo in M0; keep pubsub.spec.ts as the permanent
independent oracle; Message any->unknown moves to M4. New open questions:
Q1 (hierarchical opt-in), Q7 (createPubSub vs hook-bus integration), Q8
(symbol token delivery).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* docs: lock v2 API via persona-lens critique (09) + pre-M0 milestone fixes

Four persona lenses (API/DX, types, performance, release-risk) critiqued the
round-2 design; all returned GO-WITH-CHANGES. 09-lens-verdicts-and-impl-spec.md
records the consensus, the locked API, and the M1 inter... (continued)

25 of 25 branches covered (100.0%)

Branch coverage included in aggregate %.

162 of 162 relevant lines covered (100.0%)

27.75 hits per line