dangernoodle-io / TaipanMiner / 28101823231

90%

Build Type

push

github

Committed by web-flow

Commit Message

feat(stratum): force WiFi reassociation after repeated connect failures (TA-440) (#564)

The '3am idle disconnect' zombie scenario: WiFi stays associated and
bb_wifi_has_ip() returns true, but the network path is silently dead (the
router dropped the NAT/association without sending a deauth). The
wifi_reconn FSM never fires because no WIFI_EVENT_STA_DISCONNECTED event
arrives, so getaddrinfo()/connect to the pool fails forever.

Fix: add a connect-establishment failure counter (s_wifi_kick_fail_count)
in stratum_task(), separate from s_consecutive_fail_count (which is the
mid-session read-error counter for pool failover — left untouched). When
the counter reaches STRATUM_WIFI_KICK_THRESHOLD (5) and bb_wifi_has_ip()
is still true, call bb_wifi_force_reassociate() to break the stale WiFi
association and let the FSM rebuild a live path, then reset the counter.

Gating signal: all connect-establishment failures are counted (not just
DNS failures). This is correct because stratum_connect() already gates on
bb_wifi_has_ip() internally — if WiFi is legitimately down, it returns
early before DNS and the outer bb_wifi_has_ip() check at the kick site
suppresses the kick. Any -1 from stratum_connect() when has_ip is true
is therefore a path-dead condition (DNS resolves but NAT is dead, or
TCP connect hangs). The rare false-positive (pool down but reachable)
causes at most one ~5s reassociation, which is acceptable.

The callback approach recorded in the KB ("WiFi zombie state recovery via
callback kick") was chosen to avoid a circular CMake dep. That dep is
gone: components/stratum/CMakeLists.txt already REQUIRES bb_wifi and
stratum_io.c already calls bb_wifi_has_ip() at line 307. Direct call.

The threshold decision is extracted into stratum_should_kick_wifi() in
stratum_machine.c (already in build_src_filter for native envs) and
unit-tested across all branches: below threshold, at threshold with/without
IP, above threshold with/without IP. 501/501 host tests p... (continued)

Coverage Stats

2886 of 3627 branches covered (79.57%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

5385 of 5540 relevant lines covered (97.2%)

149095.44 hits per line