opendefensecloud / solution-arsenal / 28087886196
76%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 65
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 75.543% (+0.08%) from 75.468%
28087886196

push

github

web-flow 
fix(ci): make Makefile the source of truth for e2e K8s version (v1.36.1) (#648)

## What
Fix the E2E workflow by making the Makefile the single source of truth
for the K8s version: bump `ENVTEST_K8S_VERSION` to `1.36.1` and let
`make e2e-cluster` own Kind cluster creation instead of the workflow.

## Why
The workflow pre-created the `solar-test-e2e` cluster via
`helm/kind-action`, while `make test-e2e` (`make e2e-cluster` →
`ensure-kind-cluster.sh`) created its own cluster pinned to
`KIND_NODE_IMAGE` (derived from `ENVTEST_K8S_VERSION`). Two creators
with two version values meant they could disagree — and they did,
breaking E2E. The first attempted bump also exposed that
`kindest/node:v1.36.0` was never published; `v1.36.1` is the real tag.
Now the version lives only in the Makefile, `kind` is just a binary the
workflow installs, and `make e2e-cluster` is the sole creator (no-op
reuse when the cluster already matches).

## Testing
CI E2E run on this branch.

## Notes for reviewers
- `ENVTEST_K8S_VERSION 1.36.0 → 1.36.1`; `KIND_NODE_IMAGE` auto-derives
`kindest/node:v1.36.1`, and envtest fetches `1.36.1` via the sideload
script (dl.k8s.io on Linux CI).
- Removed the `helm/kind-action` step; `kind v0.31.0` is now installed
in the `Install Tools` step. Cluster creation is fully owned by `make
e2e-cluster` in the suite's `BeforeSuite`.
- Follow-up (separate issue/PR, not here): migrate all CI workflows to
run under nix so every tool version comes from the dev shell instead of
hardcoded installs.

## Checklist
- [x] ~~Tests added/updated~~ n/a
- [x] No breaking changes (or upgrade path documented above)
- [x] Readable commit history (squashed and cleaned up as desired)
- [x] AI code review considered and comments resolved

4037 of 5344 relevant lines covered (75.54%)

34.27 hits per line

Coverage Regressions

Lines Coverage ∆ File
2
86.13
 -0.45% pkg/controller/rendertask_controller.go
2
73.66
 0.38% pkg/controller/target_controller.go
Jobs
ID Job ID Ran Files Coverage
1 28087886196.1 65
75.54
 GitHub Action Run
Source Files on build 28087886196