iotaledger / iota-rust-sdk / 28069441485

36%

Build Type

push

github

Committed by web-flow

Commit Message

refactor: remove deprecated zklogin variants from public signature enums (#1195)

* refactor: remove deprecated zklogin variants from public signature enums

Drop ZkLoginAuthenticatorDeprecated from the public UserSignature and
SignatureScheme enums. Neither is serialized by variant index
(UserSignature uses a custom flag-byte encoding, SignatureScheme uses an
explicit #[repr(u8)]), so removing them does not shift any BCS
discriminants and needs no serde-specific placeholder.

The 0x05 flag is left documented as reserved. The index-locked
placeholders on the private BinaryPublicKey / MemberSignature serde
structs are kept, since removing those would shift the on-chain wire
format.

https://claude.ai/code/session_01GKkvevz4vSZike1ryqCQMz

* test: pin BCS tags for signature enums touched by zklogin removal

Round-trip tests can't catch a shifted discriminant (encode and decode
move together), so add hardcoded-value anchors:

- signature_scheme_flag_values: pins every SignatureScheme flag byte and
  asserts the reserved 0x05 (zklogin) is rejected.
- user_signature_rejects_zklogin_flag: a bare 0x05 flag must no longer
  decode.
- member_signature_bcs_tags: pins the multisig MemberSignature tags,
  guarding the retained ZkLoginDeprecated placeholder that keeps Passkey
  at tag 0x04.

https://claude.ai/code/session_01GKkvevz4vSZike1ryqCQMz

---------

Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Thibault Martinez <thibault@iota.org>

Coverage Stats

39 of 40 new or added lines in 2 files covered. (97.5%)

25 existing lines in 9 files now uncovered.

7979 of 22547 relevant lines covered (35.39%)

10154.59 hits per line