uclibs / application_portfolio / 28053359154

74%

push

circleci

Libappo1 108 migrate java script loading (#445)

* Migrate JavaScript from Sprockets to the esbuild bundle (LIBAPPO1-108).

Move app scripts into app/javascript/, bundle Turbo, Bootstrap, Chartkick,
and Active Storage via esbuild, serve the committed builds/application.js
from layouts, and retire the Sprockets javascripts manifest.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Clean up post-Sprockets JS migration from code review.

Drop obsolete Bootstrap JS vendoring, harden filter UI scripts, restore
vendor! spec cleanup, and ensure the esbuild bundle exists in the test suite.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Fix Bootstrap dropdown regression and harden JS modules.

Load the full Bootstrap ESM entry via bootstrap_setup so dropdown data-api
works, bind all created-by sanitization fields, and rename test support to
asset_builds.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Harden Turbo-aware JS handlers from code review.

Use delegated input sanitization, safer tab hash matching, skip
already-visible flash toasts, and align esbuild build spec assertions.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Polish JS migration from detailed code review.

Add stale-bundle detection, shared esbuild spec helpers, close sidenav
before Turbo cache, simplify multivalue module, fix README yarn.lock
wording, and remove dead javascripts scaffolding.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Harden JS migration with CI bundle check and tracked yarn.lock.

Add CircleCI verification that the committed esbuild bundle matches a fresh build, restore @popperjs/core for reproducible installs, assert dashboard Chartkick markup in requests, and commit yarn.lock for deterministic dependency resolution.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Address code review findings from the JS migration branch.

Honor SKIP_JS_BUILD in test suite setup, fix the profile request spec path, remove an unused window global, dedupe filter... (continued)

318 of 478 branches covered (66.53%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 2 files covered. (100.0%)

946 of 1234 relevant lines covered (76.66%)

22.44 hits per line