decentraland / sites / 28050686326

96%

push

github

fix: resolve World owner profile on /jump cards via Worlds Content Server (#563)

* fix: resolve World owner profile on /jump cards via Worlds Content Server

The places card resolved its "By <creator>" name through `getSceneMetadata`,
which always queried the main Catalyst's active entity at the Genesis City
`position` and read that scene's `deployedBy`. Worlds are not deployed on the
main Catalyst at a position — their scene lives on the Worlds Content Server
keyed by the world name — so for a World URL (e.g.
`/jump?realm=impssbldimnsn.dcl.eth&position=25,4`) the lookup resolved an
unrelated Genesis City scene deployer (or nothing), and the real world owner's
profile was never fetched. The card then fell back to the Places API
`contact_name`.

Make `getSceneMetadata` world-aware: when `realm` is an ENS name, fetch the
world's active scene entity from `WORLDS_CONTENT_SERVER_URL` and resolve the
owner from the entity's `metadata.owner`, looking that profile up on the
Catalyst lambdas. Genesis City keeps the existing scene deploy-audit path.
The shared profile-resolution logic is extracted into `resolveDeployerInfo`.

* fix: treat a /jump World absent from the Worlds Content Server as an invalid jump

* fix: use the owner address for the /jump creator profile link, not the display name

* fix: hide profile badges when the address has no Catalyst profile

---------

Co-authored-by: Braian Mellor <braianj@gmail.com>

4540 of 5671 branches covered (80.06%)

Branch coverage included in aggregate %.

29 of 30 new or added lines in 4 files covered. (96.67%)

7080 of 7476 relevant lines covered (94.7%)

14.78 hits per line