vocdoni / saas-backend / 28034326832

63%

Build Type

push

github

Committed by web-flow

Commit Message

fix(api): stop swagger promising response fields the API never sends (#542)

* fix(api): stop swagger promising response fields the API never sends

Several response schemas advertised fields that no response actually
carries, because they were either write-only creation inputs living on a
struct reused as both request and response, or response fields the
FromDB converter silently never populated. Clients trusted these and got
a zero value (or nothing).

- OrganizationInfo.provisionAccount was a creation-only directive on the
  shared request/response struct, so every org response documented it
  although OrganizationFromDB never sets it. Move it to a dedicated
  CreateOrganizationRequest body; OrganizationInfo (the response model)
  no longer carries it.
- OrganizationCensus.weighted was documented and stored (db.Census.Weighted,
  set at publish) but OrganizationCensusFromDB dropped it, so GET/list
  census always returned weighted=false. Populate it.
- OrganizationInfo.meta was documented but OrganizationFromDB dropped it,
  so org responses always returned meta=null. Populate it from db.Organization.
- SubscriptionDetails.maxCensusSize had no backing field on
  db.OrganizationSubscription and was always 0. Remove it.
- SubscriptionPlan.stripePriceId and startingPrice had no backing field on
  db.Plan and were never set (dead). Remove them.

The shared-model integrator field is intentionally left untouched here to
avoid conflicting with in-flight work on that flag.

Regenerated docs/swagger.yaml.

Coverage Stats

10 of 10 new or added lines in 2 files covered. (100.0%)

24 existing lines in 1 file now uncovered.

9553 of 15404 relevant lines covered (62.02%)

44.36 hits per line