opendefensecloud / solution-arsenal / 28028635635

76%

Build Type

push

github

Committed by web-flow

Commit Message

fix(discovery): exclude terminating CVs from parent Component cleanup (#642)

## What
When a `ComponentVersion` is deleted, the discovery apiwriter only
deletes the parent `Component` if no active CVs remain — terminating
siblings no longer keep it alive.

## Why
On a CV delete the apiwriter checks whether any sibling CVs still
reference the parent `Component` before deleting it. The just-deleted CV
carries a finalizer, so it lingers in `Terminating` state and was still
counted by the `len(remaining.Items) == 0` check; the parent delete was
skipped and the `Component` orphaned forever. This surfaced as the e2e
webhook discovery spec timing out for 600s waiting for the `Component`
to be garbage-collected. The fix counts only active CVs, excluding the
CV being deleted and any already in `Terminating` state.

## Testing
- New unit test (`pkg/discovery/apiwriter`) seeds a terminating sibling
CV — the state the fake clientset never reproduces on its own, which is
why this slipped past unit tests while failing e2e — and asserts the
parent `Component` is deleted; verified it fails on the pre-fix logic
and passes on the fix.
- `go test ./pkg/discovery/apiwriter/...` green; `go vet` clean.

## Notes for reviewers
This is the minimal fix to unblock the release. A follow-up will move
`Component` lifecycle into a dedicated reconciler that owns deletion
serialized per-`Component`, making it re-creation-safe and removing the
inferred-cleanup + finalizer machinery entirely (tracked by the `FIXME`
added in this PR).

## Checklist
- [x] Tests added/updated
- [x] No breaking changes (or upgrade path documented above)
- [x] Readable commit history (squashed and cleaned up as desired)
- [x] AI code review considered and comments resolved

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Bug Fixes**
* Improved component cleanup behavior so parent components are deleted
once all child component versions are removed, i... (continued)

Coverage Stats

6 of 6 new or added lines in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

4032 of 5344 relevant lines covered (75.45%)

36.7 hits per line