Qiskit / qiskit / 28019322767

88%

main: 88%

Build Type

push

github

Committed by web-flow

Commit Message

Fix qasm3 experimental exporter delay units for ms and ps (#16233)

* Fix qasm3 experimental exporter delay units for ms and ps

Two independent bugs caused `qasm3.dumps_experimental` to produce
incorrect output for `Delay` instructions with `unit="ms"` or
`unit="ps"`:

* `DurationUnit::Millisecond` was serialised with the suffix `"us"`
  instead of `"ms"` (a copy-paste in `ast.rs`), making the emitted
  duration read as 1000x smaller than intended.

* The picosecond-to-nanosecond conversion in `exporter.rs` multiplied
  by 1000 instead of dividing.  Since 1 ps = 0.001 ns, `Delay(1, 'ps')`
  was emitted as `delay[1000ns]` rather than `delay[0.001ns]`, a factor
  of 10^6 too large.

The existing Python exporter (`Exporter.dumps`) was already correct;
only the Rust-backed experimental path was affected.

Adds `TestQASM3ExporterRust.test_delay_units` covering every unit
(`ns`, `us`, `ms`, `s`, `dt`, `ps`).

Fixes #16097

* Address @gadial's review: consolidate ps case, switch to assertRegex

* Drop the redundant `("ps", 2, ...)` case; replace `("ps", 1, ...)`
  with `("ps", 1337, "delay[1.337ns]")` per @gadial's suggestion -
  this still covers the ps→ns conversion-factor direction (which is
  what bug #16097 fix #1 actually changed) but with a more distinctive
  value than `1` vs `2`.
* Replace the line-splitting + `assertIn` pattern with `assertRegex`
  against the full output, more robust to formatting variations.

* Reword release note

* Use the correct function names in release note

---------

Co-authored-by: gkneighb <gkneighb@users.noreply.github.com>
Co-authored-by: Luciano Bello <766693+1ucian0@users.noreply.github.com>
Co-authored-by: Jake Lishman <jake.lishman@ibm.com>

Coverage Stats

2 of 2 new or added lines in 2 files covered. (100.0%)

5 existing lines in 2 files now uncovered.

112776 of 128687 relevant lines covered (87.64%)

997451.13 hits per line