vocdoni / saas-backend / 28011667355

63%

Build Type

push

github

Committed by p4u

Commit Message

fix(notifications): expose per-item delivery await; remove test races

Making notification sends fire-and-forget broke the happens-before the
test suite relied on: a handler enqueued an email and returned before the
queue worker delivered it, so waitForEmail raced the worker (and, under
load, the circuit breaker could stall delivery past the poll budget).
This was latent until rebasing onto main's heavier concurrent workload
tipped it into consistent CI failures, on both the API mail path and the
CSP OTP-challenge path.

- notifications.Queue: add an optional per-item done channel and a
  PushWait(item) returning a <-chan signalled exactly once when the item
  reaches its terminal outcome (delivered or given up).
- csp/notifications.Queue (wrapper): add PushWait delegating to the inner
  queue; results still forwarded to NotificationsSent.
- api: Config.NotificationsSyncDelivery; when set, sendMail blocks on
  PushWait until delivery completes (bounded by request ctx + 30s cap).
- csp: Config.SyncDelivery; when set, BundleAuthToken/ResendChallenge
  block until the challenge is delivered (bounded by service ctx + 30s).
- both default OFF — production stays fire-and-forget.
- api tests enable both flags, so a handler that sends mail then returns
  guarantees the mail is in the fake inbox before the response is
  observed — restoring deterministic happens-before with no widened polls
  and immune to the breaker-stall path.
- add Queue.PushWait unit tests (success and give-up outcomes).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Coverage Stats

52 of 66 new or added lines in 6 files covered. (78.79%)

284 existing lines in 11 files now uncovered.

9310 of 15078 relevant lines covered (61.75%)

44.05 hits per line