ben-manes / caffeine / #5541

100%

master: 100%

push

github

fix stale expiry clock in compute and put

doComputeIfAbsent and put checked hasExpired with the method-entry
clock, unlike remap which re-reads it. A slow bin-lock wait could let an
entry expire after the read, so it was returned as a live hit
(computeIfAbsent) or a stale previous value (put). Read the clock at
point of use instead: computeIfAbsent's fast path after the lookup and
its locked branch, and put per-path (create, onlyIfAbsent fast paths,
and post-lock for the update), dropping put's up-front read.

Adds deterministic bin-lock regression tests and a Fray test.

4049 of 4054 branches covered (99.88%)

6 of 6 new or added lines in 1 file covered. (100.0%)

8242 of 8242 relevant lines covered (100.0%)

1.0 hits per line