babelfish-for-postgresql / babelfish_extensions / 28007996163

78%

Build Type

push

github

Committed by web-flow

Commit Message

Spatial Index Support in the babelfish (#4860)

Currently, Babelfish does not support the T-SQL `MULTILINESTRING` spatial type for `geometry` and `geography`. Any attempt to construct one — via `STMLineFromText`, `STMLineFromWKB`, varbinary round-trip, or text WKT input — fails with `MULTILINESTRING is not supported`. With this change, Babelfish now supports `MULTILINESTRING` end-to-end on both `geometry` and `geography`, including 2D, 3D (XYZ / XYM), and 4D (XYZM) variants, EMPTY MultiLineStrings, and round-trips through WKT and varbinary.

This change closes a long-standing T-SQL spatial-type compatibility gap that blocked Babelfish from being a drop-in for T-SQL workloads using the OGC `MULTILINESTRING` constructor and its varbinary CLR encoding.

The implementation:

- **Grammar** — adds `multilinestring_query` productions in `geo_parser.y` (2D / Z / M / ZM / EMPTY) and a `MLINESTRING_TOK` token in `geo_scan.l`.
- **WKT rewrite** — adds `rewrite_multilinestring_query` and `rewrite_dim_multilinestring_query` in `geo.c` to translate T-SQL WKT to PostGIS-flavored WKT before delegating to `LWGEOM_in`.
- **CLR ↔ PostGIS conversion** — adds full `MULTILINESTRING_TYPE` handling in `spatialtypes.c`: `handle_multilinestring_type_data` (PostGIS WKB → T-SQL CLR layout), `write_multilinestring_clr_metadata` (figure / shape arrays), `handle_multi_to_postgis` MLS branch (CLR → PostGIS WKB), latitude validation for geography MLS, and an empty-MLS path.
- **Front-end wiring** — adds `geometry_mlinestring_from_text`, `geography_mlinestring_from_text`, `geometry_mlinestring_from_wkb`, `geography_mlinestring_from_wkb` (`spatialtypes.c`), the SQL bindings in `geometry.sql` / `geography.sql`, the upgrade migration in `spatial_types--5.6.0--5.7.0.sql`, and the T-SQL parser tokens (`TSqlLexer.g4`, `TSqlParser.g4`).
- **Helper consolidation** — adds `get_multilinestring_count` so the SRID-conditional WKB offset and the count read live in exactly one place; the three call... (continued)

Coverage Stats

227 of 254 new or added lines in 3 files covered. (89.37%)

529 existing lines in 2 files now uncovered.

54981 of 71313 relevant lines covered (77.1%)

598704.95 hits per line