source-academy / frontend / 27999109661

42%

Build Type

push

github

Committed by web-flow

Commit Message

fix: conductor run button stuck on first click (#3998)

* fix: ensure conductor saga always exits and handles broken STATUS channel

- Wrap entire evalCodeConductorSaga body in try/finally so
  endInterruptExecution is guaranteed even if getPreparedConductorSaga
  throws or hangs (prevents run button permanently stuck on any error)
- Add race timeout (execTime + 10s) as fallback in case the runner
  never sends a terminal signal
- Dispatch beginInterruptExecution from handleResults after receiving
  the program result, so the saga exits cleanly even when the STATUS
  channel is broken (older evaluator bundles built with const-enum
  conductor have InternalChannelName erased to undefined, making STATUS
  messages unreachable on the host side)

* fix: remove debug logs from conductor saga

* fix: guard endInterruptExecution against cleanup failures

Nest task cancellations and conduit.terminate() in an inner try block
with endInterruptExecution in its own finally, so the UI always unlocks
even if terminate() throws. Also cancel all tasks before terminating
the conduit.

Coverage Stats

2531 of 7036 branches covered (35.97%)

Branch coverage included in aggregate %.

0 of 20 new or added lines in 1 file covered. (0.0%)

2 existing lines in 1 file now uncovered.

6034 of 13354 relevant lines covered (45.18%)

27.69 hits per line