Logflare / logflare / c812fc9139345db6ec61a8f6eda497a51d9bb4b5-PR-3626

82%

main: 82%

Build Type

Pull #3626

github

Committed by djwhitt

Commit Message

test(queue): cover stale match-spec, per-pass limit, and CAS helpers

Centralize the stale-row compare-and-swap into IngestEventQueue.reset_stale_event/3
and drop_stale_event/2 (pinning the exact observed row), and have QueueJanitor call
them instead of open-coding select_replace/select_delete. This both follows the
project's "centralize ETS transitions" guidance and makes the skip-on-mismatch
behaviour deterministically testable.

Make the per-pass limit configurable via janitor state (default unchanged) so the
overflow path can be exercised without inserting 10k rows.

New tests:
- list_stale_processing_ids/3: only :processing rows at/before the cutoff are
  returned; :pending/:ingested excluded by the status pin regardless of claimed_at;
  the returned count is bounded by the limit.
- reset_stale_event/3 and drop_stale_event/2: act on the exact row, and :skip
  (leaving the row untouched) when it was re-claimed after observation.
- janitor: telemetry reports a drop past max retries; the per-pass limit caps resets
  with the remainder recovered on a later pass.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Pull Request Pull Request #3626: refactor(ingest queue): timestamp-based stale :processing recovery

Coverage Stats

39 of 39 new or added lines in 3 files covered. (100.0%)

11 existing lines in 6 files now uncovered.

13332 of 16372 relevant lines covered (81.43%)

5075.73 hits per line