Logflare / logflare / eb627fd3139b14117a3f98d9d02b2872ee117b05-PR-3626

82%

main: 82%

Build Type

Pull #3626

github

Committed by djwhitt

Commit Message

fix(queue janitor): CAS-protect the stale drop path

The drop branch of act_on_stale_event matched any :processing row with the
target id and ignored select_delete's return, so it reported :drop even when
nothing was deleted (inflating the dropped data-loss metric) and could, in the
narrow lookup->delete window, delete a row that had been acked and re-claimed
under the same id.

Pin the exact row observed by the lookup as the CAS match in both the drop and
reset branches (which also guards claimed_at, so a freshly re-claimed row no
longer matches) and gate the :drop/:reset verdict on the operation count, so
telemetry only counts rows actually changed.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Pull Request Pull Request #3626: refactor(ingest queue): timestamp-based stale :processing recovery

Coverage Stats

29 of 35 new or added lines in 3 files covered. (82.86%)

25 existing lines in 6 files now uncovered.

13329 of 16370 relevant lines covered (81.42%)

5067.46 hits per line