supabase / supabase-flutter / 27986095786

85%

Build Type

push

github

Committed by web-flow

Commit Message

chore: enable avoid-passing-async-when-sync-expected lint (#1455)

> Stacked on top of #1454. Review/merge that one first; the base will
retarget to `main` automatically once it lands.

## What

Enables the DCM rule
[`avoid-passing-async-when-sync-expected`](https://dcm.dev/docs/rules/common/avoid-passing-async-when-sync-expected/)
(removing it from the ratchet list in `supabase_lints`) and resolves the
13 resulting violations.

## Why

When an `async` callback is passed where a synchronous one is expected,
the returned `Future` is discarded, so if it throws the error is
silently lost. This is the same class of problem as the
`unawaited_futures`/`discarded_futures` lints in #1454, just at call
sites that take a callback. Enabling it closes the remaining
async-safety gap.

## How

Each of the 13 sites was made synchronous, and the inner async work was
either wrapped in `unawaited(...)` (genuine fire-and-forget) or
extracted into a dedicated method, preserving existing behavior and
error handling. Highlights:

- `realtime_channel.dart`: extracted the `joinPush.receive('ok', ...)`
body into `_handleJoinOk(...)` (the `InvalidJWTToken` setAuth handling
is preserved verbatim).
- `realtime_client.dart`: extracted reconnect into `_reconnect()`,
heartbeat timer callback made sync with `unawaited(sendHeartbeat())`.
- `supabase_client.dart`: `onAuthStateChangeSync` listener made sync
with `unawaited(_handleTokenChanged(...))`.
- `supabase_stream_builder.dart`: `onDone: controller.close` → `onDone:
() => unawaited(controller.close())` in the asyncMap/asyncExpand
reimplementations.
- Remaining sites are in test mock servers and a widget-test stub.

No public API signatures were changed.

## Verification

- `dcm analyze`: 0 `avoid-passing-async-when-sync-expected` across all
packages.
- `dart analyze`: clean, no new `unawaited_futures`/`discarded_futures`.
- Tests: realtime_client (channel/socket/mock), supabase
(mock/utilities), and supabase_flutter suites all pass.

Coverage Stats

40 of 44 new or added lines in 5 files covered. (90.91%)

13 existing lines in 1 file now uncovered.

4106 of 4820 relevant lines covered (85.19%)

3.62 hits per line